Re: [grahame@ucs.uwa.edu.au: Patch to squid HEAD]

On 15 Nov 2001, at 16:21, Henrik Nordstrom <hno@squid-cache.org> wrote:

> Should use bitmask similar to how fd_set works, not array of char..

 Why? To conserve few KB of ram? Performance-wise char seems even faster.
 Not sure if we can use additional bits for good, though.
 Can we create a special type whose size in bits can be changed without
 a need to fix other code?

> Regards
> Henrik
>
>
> On Thursday 15 November 2001 14.50, Adrian Chadd wrote:
> > Review?
> >
> > Adrian
> >
> > ----- Forwarded message from Grahame Bowland <grahame@ucs.uwa.edu.au> -----
> >
> > Subject: Patch to squid HEAD
> > From: Grahame Bowland <grahame@ucs.uwa.edu.au>
> > To: adrian@squid-cache.org
> > X-Mailer: Evolution/0.99.0 (Preview Release)
> > Date: 15 Nov 2001 12:40:43 +0800
> >
> >
> > Hi Adrian,
> >
> > Attempting to get onto squid-dev, but until then I'll send patches to
> > you :) This patch removes the dependency on the OS specified FD_SETSIZE
> > when using polled I/O. Basically it removes fd_set from the delay pools
> > code and replaces it with an array of chars, as that was the only thing
> > tying us down to the FD_SETSIZE limit for Squid_MaxFD.
> >
> > We've been running with this on styx for a few days, since 1024
> > filedescriptors was too small.
> >
> > Anyway, patch attached and I used diff -u this time :)

------------------------------------
 Andres Kroonmaa <andre@online.ee>
 CTO, Microlink Online
 Tel: 6501 731, Fax: 6501 725
 Pärnu mnt. 158, Tallinn,
 11317 Estonia
Received on Thu Nov 15 2001 - 08:35:39 MST