Re: ETag support

On Thu, 15 Apr 2004, Mati wrote:

> > > if (!httpReplyValidatorsMatch(..

> sorry... I wasn't looking at the source whlie writing this mail
> and i hoped the question wouldn't be ambiguous... apparently i was
> wrong...
> its in
> clientReplyContext::clientGetsOldEntry() in client_side_reply.cc

If I understand correctly this part is primarily in case the server
returns a ETag incompatible with the clients request. But looking at the
httpReplyValidatorsMatch function in Squid-3 I doubt this at all works.
Each test needs the following in front:

   if (one.buf() || two.buf())

to only test for ETag or Content-MD5 it it exists in either reply..

And further, using Content-MD5 here is not a good idea as it is not
included in 304 replies.. It is an entity-header and as such MUST/SHOULD
NOT be included in 304 replies.. (RFC 2616 10.3.5 304 Not Modified,
paragraph 4 If the conditional...)

Regards
Henrik
Received on Fri Apr 16 2004 - 03:10:13 MDT