Re: Squid-2.6 comm_select_win32.c, time for a rewrite to new commloop structure?

Hi Henrik,

At 18.44 28/10/2006, Henrik Nordstrom wrote:
>lör 2006-10-28 klockan 12:41 +0200 skrev Guido Serassio:
>
> > Great !!! :-)
> >
> > Basically it seems to work.
> > But it give to me a strange feeling when loading some complex page
> > with many embedded objects, like images, style sheets or .js objects:
> > The browser doesn't complete the page load for many seconds, but at
> > the end the object is retrieved.
>
>Sounds like something broken then..

With this change, things seems to go better:

Index: src/comm_select_win32.c
===================================================================
RCS file: /cvsroot/squid/squid/src/comm_select_win32.c,v
retrieving revision 1.5
diff -u -p -r1.5 comm_select_win32.c
--- src/comm_select_win32.c 28 Oct 2006 08:56:42 -0000 1.5
+++ src/comm_select_win32.c 28 Oct 2006 16:52:27 -0000
@@ -125,7 +125,7 @@ do_comm_select(int msec)
      if (num == 0)
         return COMM_TIMEOUT;

- for (fd = 0; fd < Biggest_FD; fd++) {
+ for (fd = 0; fd <= Biggest_FD; fd++) {
         int read_event = __WSAFDIsSet(fd_table[fd].win32.handle, &readfds);
         int write_event =
__WSAFDIsSet(fd_table[fd].win32.handle,
&writefds) || __WSAFDIsSet(fd_table[fd].win32.handle, &errfds);
         if (read_event || write_event)

Regards

Guido

-
========================================================
Guido Serassio
Acme Consulting S.r.l. - Microsoft Certified Partner
Via Lucia Savarino, 1 10098 - Rivoli (TO) - ITALY
Tel. : +39.011.9530135 Fax. : +39.011.9781115
Email: guido.serassio@acmeconsulting.it
WWW: http://www.acmeconsulting.it/
Received on Sat Oct 28 2006 - 10:53:57 MDT