Re: SNMP support starts on branch squid3-ipv6 !! [improved]

Henrik Nordstrom wrote:
> On fre, 2007-11-23 at 23:55 +1300, Amos Jeffries wrote:
>
>> SNMPv2-SMI::enterprises.3495.1.5.1.1.1.192.168.0.12 = STRING:
>> "rio.treenetnz.com"
>> Error: OID not increasing:
>
> This is inherent to our broken way of indexing the peers. Not unique to
> ipv6 but also seen for ipv4 peers even before the ipv6 modifications,
> and also in Squid-2 since the day it got SNMP support..
>
> As I said earlier the method of indexing the peers based on their IP is
> broken, not only because we do not sort the peers on their IP but also
> because there may be multiple peers on the same IP or same IP:PORT
> even..
>
> Regards
> Henrik

Yeah, I though Rafael was fixing that after our earlier discussions
about keys to use. I guess not (yet) though.

The order still appears to be broken even if there was another level to
the key. The IPA being out of order regardless of how they are configured.
My reading of the code indicates its a linked-list of peers, right?
If so they can/should be sorted into position using < or > operators on
IPAddress to get around this simple case to a large degree. It will
still be needed anyway if the key gets expanded later.

Good to know about that -cC trick.

Amos
Received on Fri Nov 23 2007 - 07:31:03 MST