Re: excessive RAM growth due to unlimited adapted body data consumption

On 08/18/2009 02:11 AM, Martin Huter wrote:
> squids ICAP adaptation implementation does not check adapted body-pipes buffer
> size before reading from an ICAP-server.
>
> If the client does not read from the open connection (i.e. the user does not
> confirm the browsers download-message-box in microsofts IE), squid keeps on
> reading data from the ICAP server into the body pipe, whilst no more data
> can be delivered to the client.
> Thus the adapted body pipes buffer is growing unlimited which causes excessive
> RAM growth.
>
> this issue was reported as bugzilla bug 2619 and the attached patch (applies
> to 3.1 and 3.HEAD) should fix the issue.
>
> please review the patch and feel free to comment it.

+1

I have reviewed the functional changes in the patches for this bug and
agree with them.

Ideally, a few things should be renamed and polished, but I do not have
the time to work on that right now. If nobody else has the time, the
patches can be committed without polishing as they do fix a rather
important and difficult to track bug.

Thank you,

Alex.
P.S. Please subscribe Martin if you can.

> -----------
>
> i would like to subscribe the squid-dev mailing list.
> my name is martin huter. i'm working as progammer at phion AG in austria.
> i'm mainly working with C and C++ and among others i am responsible for our
> squid service. currently i'm updating squid to version 3.1.
>
> p.s.: many thanks to alex rousskov for his patient help on the appended patch.
>
> cheers
> martin huter
>
>
>
Received on Thu Aug 20 2009 - 21:05:27 MDT