Re: [PATCH] Support ICY protocol (ICECast / ICEShout servers) in Squid-3

From: Henrik Nordstrom <henrik_at_henriknordstrom.net>
Date: Mon, 02 Nov 2009 22:22:41 +0100

mån 2009-11-02 klockan 00:43 +1300 skrev Amos Jeffries:
> Since we have no central place where the headers are upgraded I've had
> to skip porting the upgrade_http0.9 hack in Squid-2 and go straight to
> accepting ICY protocol as an accepted response protocol and handling it.

What do you mean by "no central place"?

Internally the headers should always be upgraded. To implement the
squid-2 option then all that is needed is to detect when the header have
been upgraded and then skip to send the header to the client.

Just remember to not enable chunked encoding for the response..

> Somewhat primitive for now. It's limited to parsing and regenerating the
> status line correctly, and

Do this mean HTTP status lines is also properly preserved now?

> skipping the HTTP/1.0 version override on
> non-HTTP protocol replies.

Right.

What Squid-2 does is to add that header internally with HTTP/0.9 as
version. The version is overridden anyway when the response is composed.

> Since it is on port 80 I've temporarily left the HTTP/1.1 required
> header alterations happening. Some testing will be needed over the next
> few days to ensure that the client software treats unknown headers
> nicely. If needed overrides for those are easily done as well now.

Or fall back on what squid-2 does.. internally upgrade but then skip
sending an HTTP header out..

Regards
Henrik
Received on Mon Nov 02 2009 - 21:22:48 MST

This archive was generated by hypermail 2.2.0 : Tue Nov 03 2009 - 12:00:03 MST