Re: question about submitting patch

Amos Jeffries wrote:
> On Thu, 5 Nov 2009 00:58:00 +0100, Kinkie <gkinkie_at_gmail.com> wrote:
>
>> If you are using a bzr feature-branch, you can use the "bzr send"
>> command to submit to the squid-dev a full bundle (including revision
>> history etc).
>> It will then also be picked up by BundleBuggy for review and to assist
>> in merge voting.
>>
>> Kinkie
>>
>
> pPS: preferrably adding [MERGE] prefix to the email subjects of these
> submissions to assist us tracking them even when BundleBuggy goes down or
> gets delayed.
>
> Amos
>
Sure! Hey, is this output from test-builds ok? It looks like it's
failing some tests that have been set to "ignore" (though I'm not
familiar with cppunit in particular). This output is from HEAD.

TESTING: layer-00-bootstrap
BUILD: .././test-suite/buildtests/layer-00-bootstrap.opts
TESTING: layer-00-default
BUILD: .././test-suite/buildtests/layer-00-default.opts
make[3]: [clean-noinstLIBRARIES] Error 1 (ignored)
TESTING: layer-01-minimal
BUILD: .././test-suite/buildtests/layer-01-minimal.opts
TESTING: layer-02-maximus
BUILD: .././test-suite/buildtests/layer-02-maximus.opts
make[3]: [clean-noinstLIBRARIES] Error 1 (ignored)
TESTING: layer-05-nodeps-esi
BUILD: .././test-suite/buildtests/layer-05-nodeps-esi.opts
make[3]: [clean-noinstLIBRARIES] Error 1 (ignored)

>
>> On Thu, Nov 5, 2009 at 12:05 AM, Henrik Nordstrom
>> <henrik_at_henriknordstrom.net> wrote:
>>
>>> You are missing the openssl development package, usually openssl-devel
>>> or libssl-dev depending on OS flavor.
>>>
>>> Patches are submitted as an unified diff attached to a squid-dev
>>> message, preferably with [PATCH] in the subject to make it stick out
>>> from the other discussions..
>>>
>>>
>>> ons 2009-11-04 klockan 17:23 -0500 skrev Matthew Morgan:
>>>
>>>> Ok, I think I've got the kinks worked out regarding setting
>>>> range_offset_limit per a pattern. I've done a decent bit of testing,
>>>>
> and
>
>>>> it seems to be working as intended. I did added a file to the source
>>>> tree, and I'm pretty sure I've updated Makefile.am properly.
>>>>
>
> Looking forward to seeing this.
> By "per a pattern" do you mean a regex pattern based on URL or (more
> preferred) a list of ACLs?
>
>
>>>> I tried to do a ./test-builds, but it fails identically in my test
>>>> repository and in trunk, in areas of squid I didn't touch. I guess
>>>>
> HEAD
>
>>>> doesn't always pass? It may be that I don't have some headers that
>>>>
> it's
>
>>>> looking for. Here's the output of the test-builds script:
>>>>
>
> We have not quite finished stabilizing the build behavior of all
> components. This is a bug in trunk seemingly unrelated to your code. It
> should have skipped or died much earlier than build on a useful dependency
> missing message. Thanks for finding and pointing this out.
>
>
>>>> TESTING: layer-00-bootstrap
>>>> BUILD: .././test-suite/buildtests/layer-00-bootstrap.opts
>>>> TESTING: layer-00-default
>>>> BUILD: .././test-suite/buildtests/layer-00-default.opts
>>>> ../../../src/ssl_support.h:55: error: expected constructor,
>>>>
> destructor,
>
>>>> or type conversion before ‘*’ token
>>>> ../../../src/ssl_support.h:58: error: expected constructor,
>>>>
> destructor,
>
>>>> or type conversion before ‘*’ token
>>>> ../../../src/ssl_support.h:71: error: ‘SSL’ was not declared in this
>>>> scope
>>>> ../../../src/ssl_support.h:71: error: ‘ssl’ was not declared in this
>>>> scope
>>>> ../../../src/ssl_support.h:74: error: typedef ‘SSLGETATTRIBUTE’ is
>>>> initialized (use __typeof__ instead)
>>>> ../../../src/ssl_support.h:74: error: ‘SSL’ was not declared in this
>>>> scope
>>>> ../../../src/ssl_support.h:74: error: expected primary-expression
>>>>
> before
>
>>>> ‘,’ token
>>>> ../../../src/ssl_support.h:74: error: expected primary-expression
>>>>
> before
>
>>>> ‘const’
>>>> ../../../src/ssl_support.h:77: error: ‘SSLGETATTRIBUTE’ does not name
>>>>
> a
>
>>>> type
>>>> ../../../src/ssl_support.h:80: error: ‘SSLGETATTRIBUTE’ does not name
>>>>
> a
>
>>>> type
>>>> ../../../src/ssl_support.h:83: error: ‘SSL’ was not declared in this
>>>> scope
>>>> ../../../src/ssl_support.h:83: error: ‘ssl’ was not declared in this
>>>> scope
>>>> ../../../src/ssl_support.h:86: error: ‘SSL’ was not declared in this
>>>> scope
>>>> ../../../src/ssl_support.h:86: error: ‘ssl’ was not declared in this
>>>> scope
>>>> ./../../../src/acl/CertificateData.h:45: error: ‘SSL’ was not declared
>>>> in this scope
>>>> ./../../../src/acl/CertificateData.h:45: error: template argument 1 is
>>>> invalid
>>>> ./../../../src/acl/CertificateData.h:51: error: expected `)' before
>>>>
> ‘*’
>
>>>> token
>>>> ./../../../src/acl/CertificateData.h:55: error: ‘SSL’ has not been
>>>> declared
>>>> ./../../../src/acl/CertificateData.h:59: error: ‘SSL’ was not declared
>>>> in this scope
>>>> ./../../../src/acl/CertificateData.h:59: error: template argument 1 is
>>>> invalid
>>>> ./../../../src/acl/CertificateData.h:65: error: ISO C++ forbids
>>>> declaration of ‘SSLGETATTRIBUTE’ with no type
>>>> ./../../../src/acl/CertificateData.h:65: error: expected ‘;’ before
>>>>
> ‘*’
>
>>>> token
>>>> make[5]: *** [testHeaders] Error 1
>>>> make[4]: *** [check-am] Error 2
>>>> make[3]: *** [check-recursive] Error 1
>>>> make[2]: *** [check] Error 2
>>>> make[1]: *** [check-recursive] Error 1
>>>> make: *** [distcheck] Error 2
>>>> Build Failed. Last log lines are:
>>>> ./../../../src/acl/CertificateData.h:45: error: template argument 1 is
>>>> invalid
>>>> ./../../../src/acl/CertificateData.h:51: error: expected `)' before
>>>>
> ‘*’
>
>>>> token
>>>> ./../../../src/acl/CertificateData.h:55: error: ‘SSL’ has not been
>>>> declared
>>>> ./../../../src/acl/CertificateData.h:59: error: ‘SSL’ was not declared
>>>> in this scope
>>>> ./../../../src/acl/CertificateData.h:59: error: template argument 1 is
>>>> invalid
>>>> ./../../../src/acl/CertificateData.h:65: error: ISO C++ forbids
>>>> declaration of ‘SSLGETATTRIBUTE’ with no type
>>>> ./../../../src/acl/CertificateData.h:65: error: expected ‘;’ before
>>>>
> ‘*’
>
>>>> token
>>>> distcc[31643] ERROR: compile ./testHeaderDeps_CertificateData.cc on
>>>> localhost failed
>>>> make[5]: *** [testHeaders] Error 1
>>>> make[5]: Leaving directory
>>>>
>>>>
> `/home/lytithwyn/source/squid/trunk/btlayer-00-default/squid-3.HEAD-BZR/_build/src/acl'
>
>>>> make[4]: *** [check-am] Error 2
>>>> make[4]: Leaving directory
>>>>
>>>>
> `/home/lytithwyn/source/squid/trunk/btlayer-00-default/squid-3.HEAD-BZR/_build/src/acl'
>
>>>> make[3]: *** [check-recursive] Error 1
>>>> make[3]: Leaving directory
>>>>
>>>>
> `/home/lytithwyn/source/squid/trunk/btlayer-00-default/squid-3.HEAD-BZR/_build/src'
>
>>>> make[2]: *** [check] Error 2
>>>> make[2]: Leaving directory
>>>>
>>>>
> `/home/lytithwyn/source/squid/trunk/btlayer-00-default/squid-3.HEAD-BZR/_build/src'
>
>>>> make[1]: *** [check-recursive] Error 1
>>>> make[1]: Leaving directory
>>>>
>>>>
> `/home/lytithwyn/source/squid/trunk/btlayer-00-default/squid-3.HEAD-BZR/_build'
>
>>>> make: *** [distcheck] Error 2
>>>> buildtest.sh result is 2
>>>>
>>>>
>>>> Should I go ahead and follow the patch submission instructions on
>>>> http://wiki.squid-cache.org/Squid3VCS, or is there something I should
>>>> check first?
>>>>
>>>
>
>
Received on Thu Nov 05 2009 - 21:31:49 MST