Re: /bzr/squid3/trunk/ r10110: Style Makefile.am to use instead of @AUTOMAKEVAR

Sorry, bash ate part of that message.. Correct text:

Style Makefile.am to use $(AUTOMAKEVAR) instead of @AUTOMAKEVAR@

@AUTOMAKEVAR@ is troublesome when used in \ constructs as it may expand
to empty and the last line in a \ construct must not be empty or some
make versions will fail.

thankfully automake adds all variables for us, so using $(AUTOMAKEVAR)
is preferred.

ons 2009-11-11 klockan 12:44 +0100 skrev Henrik Nordstrom:
> ------------------------------------------------------------
> revno: 10110
> committer: Henrik Nordstrom <henrik_at_henriknordstrom.net>
> branch nick: trunk
> timestamp: Wed 2009-11-11 12:44:58 +0100
> message:
> Style Makefile.am to use instead of @AUTOMAKEVAR
>
> @AUTOMAKEVAR@ is troublesome when used in \ constructs as it may expand
> to empty and the last line in a \ construct must not be empty or some
> make versions will fail.
>
> thankfully automake adds all variables for us, so using
> is preferred.
> modified:
> scripts/srcformat.sh
> vanligt textdokument-bilaga (r10110.diff)
> === modified file 'scripts/srcformat.sh'
> --- a/scripts/srcformat.sh 2009-08-23 03:08:22 +0000
> +++ b/scripts/srcformat.sh 2009-11-11 11:44:58 +0000
> @@ -36,8 +36,16 @@
> else
> rm $FILENAME.astylebak
> fi
> - continue;
> + continue
> fi
> + ;;
> +
> + Makefile.am)
> +
> + perl -i -p -e 's/@([A-Z0-9_]+)@/\$($1)/g' <${FILENAME} >${FILENAME}.styled
> + mv ${FILENAME}.styled ${FILENAME}
> + ;;
> +
> esac
>
> if test -d $FILENAME ; then
>
Received on Wed Nov 11 2009 - 12:31:19 MST