Re: /bzr/squid3/trunk/ r10149: skip performing C libTrie unit tests

On Fri, Nov 20, 2009 at 9:36 PM, Robert Collins
<robertc_at_robertcollins.net> wrote:
> On Fri, 2009-11-20 at 21:02 +0100, Francesco Chemolli wrote:
>> ------------------------------------------------------------
>> revno: 10149
>> committer: Francesco Chemolli <kinkie_at_squid-cache.org>
>> branch nick: trunk
>> timestamp: Fri 2009-11-20 21:02:00 +0100
>> message:
>>   skip performing C libTrie unit tests
>
> Please include motivation in commit messages. The diff shows that you
> skipped the C tests, but not why.
>
> And because the motivation is missing, I'm left asking 'why?' Untested
> code is broken code, so this really can't be the right answer.

Ok, I'll be more detailed in the future.
As for this case: the autoconf environment is pretty messy in
"non-canonicalized" environments such as Solaris. In particular, the C
tests require linking against libstdc++, which causes two kind of
issues: finding it (there's at least 6 of the buggers in the test
zone), and finding the one with the right ABI (gcc/sunstudio cc).
Since we're not using the C interface anyways, might as well skip the checks.

-- 
    /kinkie