[PATCH] Solaris /dev/poll support for Squid 3 (how can I contribute)

  Hello Amos,

thank you for your response. Please find attached the four files in
question.

Companies to mention as sponsors are BBC (UK), Siemens IT Solutions and
Services (UK).

Credit to Peter Payne, Pirosa Limited UK (no e-mail please).

Squid bug 3057 was raised by another member of Siemens IT Solutions and
Services during testing of Squid 3.1.8 on Solaris - that bug was not
produced on the 32-bit compile, just the 64-bit compile. It is not
thought this is related to the /dev/poll support added here.

Note that while porting comm_devpoll.cc I have suspicions that the
comm_epoll.cc commResetSelect() function does nothing (i.e., it calls
commSetSelect with no type flag, which I suspect is a no-op for all
intents and purposes). I haven't confirmed this, however, so haven't
raised it as a bug. Someone may want to double-check.

Kind regards,
Peter Payne

On 10/09/10 02:26, Amos Jeffries wrote:
> On 08/10/10 23:13, Peter Payne wrote:
>> Dear Mailing List,
>>
>> I have a contribution to make, a C++ file (and autoconf patches) for
>> /dev/poll Solaris support, ported from Squid-2 and in use on the BBC
>> (UK) estate managed by Siemens UK with permission from the BBC to
>> publish to the Squid open-source project.
>>
>> I've not contributed to an open source project before and unsure how to
>> deliver the patch. We (at the BBC/Siemens) would like to see the patch
>> included so that future releases of Squid shall have the Solaris
>> /dev/poll support supplied (reducing the need for us to patch each
>> following release manually).
>>
>> If one of you were to e-mail me directly I would be happy to provide the
>> following:
>> comm_devpoll.cc - /dev/poll support file to add to /src/ subdir
>> squid-root.diff - unified diff to update configure.in in the / subdir
>> squid-include.diff - unified diff to update autoconf.h.in in the
>> /include/ subdir
>> squid-src.diff - unified diff to update files Makefile.in and unlinkd.cc
>> in the /src/ subdir
>>
>> The support for /dev/poll will be automatically detected by configure
>> and conditionally compiled in.
>
>
> Greetings Peter,
> Thank you very much for this.
>
> Our procedure for patch inclusion is relatively simple:
>
> * Post the unified-diff format patches here to the squid-dev list.
> * with a subject starting "[PATCH] "
> * who to credit as author(s), default is the senders name and email.
> * message text describing hat it does for the public commit record
> and to assist people understand the code.
> * companies where relevant mention as thanks or sponsors
> (these last two are covered by the email you already sent).
>
> One or more of us will do an audit that it fits on 3.HEAD then reply
> with any updates that may be needed.
>
> Most of that you have done already, we just need the patches posted
> with author details to start the audit cycle.
>
>
> On the administrative side. I'm not sure this one is /dev/poll
> related, but with the info that BBC is using your patch this reporters
> address and build options looks a little suspicious:
> http://bugs.squid-cache.org/show_bug.cgi?id=3057
> If you can sight it without the patch or can't sight it at all thats
> fine, but if introduced it will need fixing.
>
>
> Amos Jeffries
> Squid HTTP Proxy Project
>