Re: [PATCH] log error details

On 10/13/2010 07:25 AM, Tsantilas Christos wrote:

>> You might even drop that down to "EXCEPTION_a10b" for size reducing.

> Maybe it is better to use a constant form for the err_detail formating
> code:
> DESCR[=anID]
> It will be simpler for log analysers, but I have not strong opinion.
>
> Should we change the SYSERR=errorcode to a SYSERR_errorcode format too?

I think that it is better to use '=' as a separator everywhere we log
additional error details.

We may add lists of such codes (Amos' request from the first patch
review) and other additional info later, making '_' look increasingly
inappropriate.

If some log processing tool drops everything after '=', it will still
work correctly but will miss some of the information because it does not
know about our new features. That is fine and might even be desirable as
we extend details, I think.

Thank you,

Alex.
Received on Thu Oct 14 2010 - 18:10:55 MDT