Re: Two patches for better heimdal support

Hi Amos,

   I don't see that these two have been applied. Heimdal introduced a header
file gssapi_krb5.h which was previously only available in some older MIT
releases. To avoid issues on for example FreeBSD 8.1 I had to change the
include checks.

Markus

"Markus Moeller" <huaraz_at_moeller.plus.com> wrote in message
news:ibpome$psh$1_at_dough.gmane.org...
> Here is an update using only #if / #elif and changed the order a bit.
>
> Markus
>
> "Amos Jeffries" <squid3_at_treenet.co.nz> wrote in message
> news:104be24899d2c3a232288ea0fa5a7fc4_at_mail.treenet.co.nz...
>> On Sun, 14 Nov 2010 18:37:39 -0000, "Markus Moeller"
>> <huaraz_at_moeller.plus.com> wrote:
>>> Hi
>>>
>>> I noticed that the trunk does not compile on FreeBSD with Heimdal.
>> Here
>>> are two patches against the trunk.
>>>
>>> Markus
>>
>> These appear to be reversions of the file-based inclusions. Would it not
>> be better just to add:
>>
>> +#if HAVE_GSSAPI_GSSAPI_EXT_H
>> +#include <gssapi/gssapi_ext.h>
>> +#endif
>>
>> to the end of the include lists?
>>
>> Also, it is adding quite a messy mix of ifdef and if defined(). Please
>> just use #if / #elif either way.
>>
>> Amos
>>
>>
>
Received on Sun Dec 05 2010 - 12:25:08 MST