Re: Two patches for better heimdal support

From: Henrik Nordström <henrik_at_henriknordstrom.net>
Date: Mon, 06 Dec 2010 22:24:33 +0100

Applied

mån 2010-12-06 klockan 21:12 +0000 skrev Markus Moeller:
> Sorry I have another addition for config.test
>
> === modified file 'helpers/external_acl/kerberos_ldap_group/config.test'
> --- helpers/external_acl/kerberos_ldap_group/config.test 2010-12-05
> 00:25:25 +0000
> +++ helpers/external_acl/kerberos_ldap_group/config.test 2010-12-06
> 21:09:15 +0000
> @@ -9,6 +9,9 @@
> if [ -f /usr/lib/libsasl.la -o -f /usr/lib/libsasl2.la ];
> then
> exit 0
> fi
> + if [ -f /usr/lib/libsasl.so -o -f /usr/lib/libsasl2.so ];
> then
> + exit 0
> + fi
> if [ -f /usr/local/lib/libsasl.so -o -f
> /usr/local/lib/libsasl2.so ]; then
> exit 0
> fi
>
> Markus
>
>
> "Markus Moeller" <huaraz_at_moeller.plus.com> wrote in message
> news:idde7p$8a5$1_at_dough.gmane.org...
> > Hi Amos,
> >
> > Please find attached more patches for better heimdal support as new
> > heimdal version have gssapi_krb5 header files which were in the past only
> > in
> > older MIT releases available.
> >
> > 1) kerberos_ldap_group_header.diff fixes the gssapi_krb5 header issue
> >
> > Secondly to use kerberos_ldap_group on freebsd config.test has to be
> > changed as freebsd installs additional packages in /usr/local. The
> > following
> > patch addresses this
> >
> > 2) kerberos_ldap_group_config.diff
> >
> > Thirdly on freebsd 7 the krb5.h file does not work with C++. This patch
> > checks for it
> >
> > 3) kerberos_ldap_group_freebsd.diff (it includes the
> > kerberos_ldap_group_header.diff patch)
> >
> > Regards
> > Markus
> >
> > "Markus Moeller" <huaraz_at_moeller.plus.com> wrote in message
> > news:ibpome$psh$1_at_dough.gmane.org...
> >> Here is an update using only #if / #elif and changed the order a bit.
> >>
> >> Markus
> >>
> >> "Amos Jeffries" <squid3_at_treenet.co.nz> wrote in message
> >> news:104be24899d2c3a232288ea0fa5a7fc4_at_mail.treenet.co.nz...
> >>> On Sun, 14 Nov 2010 18:37:39 -0000, "Markus Moeller"
> >>> <huaraz_at_moeller.plus.com> wrote:
> >>>> Hi
> >>>>
> >>>> I noticed that the trunk does not compile on FreeBSD with Heimdal.
> >>> Here
> >>>> are two patches against the trunk.
> >>>>
> >>>> Markus
> >>>
> >>> These appear to be reversions of the file-based inclusions. Would it not
> >>> be better just to add:
> >>>
> >>> +#if HAVE_GSSAPI_GSSAPI_EXT_H
> >>> +#include <gssapi/gssapi_ext.h>
> >>> +#endif
> >>>
> >>> to the end of the include lists?
> >>>
> >>> Also, it is adding quite a messy mix of ifdef and if defined(). Please
> >>> just use #if / #elif either way.
> >>>
> >>> Amos
> >>>
> >>>
> >>
> >
>
Received on Mon Dec 06 2010 - 21:24:37 MST

This archive was generated by hypermail 2.2.0 : Tue Dec 07 2010 - 12:00:04 MST