Re: Build failed in Hudson: 3.1-amd64-CentOS.5 #226

On 20/12/10 22:28, Tsantilas Christos wrote:
> On 12/20/2010 07:05 AM, noc_at_squid-cache.org wrote:
>> depbase=`echo client_side_reply.o | sed 's|[^/]*$|.deps/&|;s|\.o$||'`; \
>> if g++ -DHAVE_CONFIG_H
>> -DDEFAULT_CONFIG_FILE=\"<http://build.squid-cache.org/job/3.1-amd64-CentOS.5/ws/btlayer-00-default/squid-3.1.9-BZR/_inst/etc/squid.conf\">
>> -DDEFAULT_SQUID_DATA_DIR=\"<http://build.squid-cache.org/job/3.1-amd64-CentOS.5/ws/btlayer-00-default/squid-3.1.9-BZR/_inst/share\">
>> -DDEFAULT_SQUID_CONFIG_DIR=\"<http://build.squid-cache.org/job/3.1-amd64-CentOS.5/ws/btlayer-00-default/squid-3.1.9-BZR/_inst/etc\">
>> -I../.. -I../../include -I../../src -I../include -I../src -Wall
>> -Wpointer-arith -Wwrite-strings -Wcomments -Werror -D_REENTRANT -g -O2
>> -MT client_side_reply.o -MD -MP -MF "$depbase.Tpo" -c -o
>> client_side_reply.o ../../src/client_side_reply.cc; \
>> then mv -f "$depbase.Tpo" "$depbase.Po"; else rm -f "$depbase.Tpo";
>> exit 1; fi
>> ../../src/client_side.cc: In member function ‘virtual void
>> ConnStateData::noteMoreBodySpaceAvailable(RefCount<BodyPipe>)’:
>> ../../src/client_side.cc:2886: error: could not convert
>> ‘ConnStateData::handleRequestBodyData()’ to ‘bool’
>> ../../src/client_side.cc:2886: error: in argument to unary !
>> make[4]: *** [client_side.o] Error 1
>
>
> I suppose is from bug 3113. The handleRequestBodyData is not bool in
> squid-3.1.
> I have a patch here which converts the handleRequestBodyData to bool but
> needs some testing.
>

Yes. The new code depends on it returning false when the FD was closed.
I've converted it to do so.

Amos

-- 
Please be using
   Current Stable Squid 2.7.STABLE9 or 3.1.9
   Beta testers wanted for 3.2.0.3