Re: [PATCH] Service Overload Handling (ICAP Max-Connections)

On 05/11/2011 12:33 PM, Amos Jeffries wrote:
> On 11/05/11 21:00, Tsantilas Christos wrote:
>> On 05/10/2011 03:44 AM, Amos Jeffries wrote:
>>>>
>>>> Maybe we can use
>>>> if (!Ip::EnableIpv6 || Ip::EnableIpv6&IPV6_SPECIAL_SPLITSTACK &&
>>>> !cfg().ipv6))
>>>
>>> No need. There are four stacks:
>>> IPv4-only
>>> Split (Classical Dual)
>>> Hybrid (Extended Dual)
>>> IPv6-only
>>>
>>> When !Ip::EnableIpv6 the default anyAddr is made IPv4-only. For the
>>
>> Looking the ip/Address.cc code I think this is not true. The default
>> localhost address is IPv4-only but for the anyAddr the family (AF_INET
>> or AF_INET6) is unspecified.
>>
>
> Grr, optimization hell. Three made with the side effect that a large
> memcpy from v4_anyaddr is no longer done on construct, SetEmpty(),
> SetIPv4(), or GetAddrInfo().
>
> Okay you were right.

OK, thank you.
I will keep the last patch as is for now.

>
> Amos
Received on Wed May 11 2011 - 10:00:33 MDT