Re: [PATCH] Separate SSL error detail name and message

Just a question on this patch.
Should I update the "Release Notes" about the new error page formating code?

On 05/13/2011 11:12 AM, Tsantilas Christos wrote:
> On 05/11/2011 03:22 PM, Amos Jeffries wrote:
>> On 11/05/11 22:10, Tsantilas Christos wrote:
>>> Currently, SSL error detail in Squid-generated error pages (%D) contains
>>> both the error name and the explanation text.
>>>
>>> Some folks using this feature want to render the two pieces of
>>> information differently because the error name is not something most
>>> end-users should read or focus on.
>>>
>>> This patch adds the "%x" error page formating code which prints the
>>> error name, and removes the error name (%err_name) from SSL error detail
>>> messages.
>>>
>>> This is a Measurement Factory project
>>
>> Please use the bool building_deny_info_url to prevent whitespace
>> ("[Unknown Error Code]") in the NIL case being added to URLs.
>
> Document the "%x" to the deny_info parameter required too...
>
> (Also a " if (!building_deny_info_url) break;" must added for the "%D"
> error code, todo )
>
> If there is not any objection I will commit this patch later today.
>
>>
>> +0. Okay.
>>
>> Amos
>
Received on Fri May 13 2011 - 11:02:35 MDT