Re: StringNG merge?

On 4/11/2012 12:55 a.m., Kinkie wrote:
> Hi all,
> Is it maybe time to resuscitate StringNG, with the target of merging
> in time for 3.3?

It is too late for 3.3 features and polish now.
But 3.4 is not scheduled for branching until next March and StringNG
should be able to make that IMO.

> I have unrotten the code, which now compiles and passes the unit
> tests, with Amos' recent changes to RefCountable/Lockable.
> The only API objection I remember (SBuf::terminate() being public) was
> fixed some time ago -

I had an objection that terminate() as a function was not necessary at all.
I want to check my patch against the current code and complete that
discussion before merge.

> I guess that the code was ready for merging but
> held off due to merge window being closed.

Uhm, we have no "merge windows" as such. The periods when I need no
commits is just a few minutes on the branching dates. After which the
branch is all that closes, but trunk remains open for merges and commits
at all other times.

> Only recent change is the renaming of SBuf::findAny to find_first_of
> for consistency with std::string.
> Feature-branch is at lp:~kinkie/squid/stringng
>
> If we agree, any preference on how to proceed?

Waiting for that agreement. Then merge.

I should have time over the next day to check the bits I want to check.

Amos
Received on Sat Nov 03 2012 - 12:56:49 MDT