Re: [PATCH] update port protocol parameter

On 07/24/2013 10:24 PM, Amos Jeffries wrote:
> On 25/07/2013 4:08 p.m., Alex Rousskov wrote:
>> On 07/22/2013 09:36 AM, Amos Jeffries wrote:
>>> How does this one suit you?
>>>
>>> "
>>> Update the http(s)_port directives protocol= parameter to use
>>> AnyP::ProtocolVersion for internal storage instead of opaque string
>>> text.
>>>
>>> This both limits the possible parameter values to one of HTTP, HTTP/1.1,
>>> HTTPS or HTTPS/1.1 and ensures that URLs generated from that protocol
>>> parameter value are http:// and https:// URL.
>>> "
>> You may want to add a note that previously allowed but now illegal
>> protocol values will result in Squid quitting.
>
> With that note and the constructor removal which I did shortly after
> posting the patch. Are you happy for this to go in?

Glad you found a way to remove the constructor! Happy would be an
exaggeration, but I have no objections for the latest patch to be committed.

Thank you,

Alex.
Received on Thu Jul 25 2013 - 15:33:50 MDT