Re: [MERGE] SBuf CacheMgr integration

On 10/10/2013 5:36 a.m., Alex Rousskov wrote:
> On 10/09/2013 10:14 AM, Kinkie wrote:
>> I'm sorry, but it doesn't seem so either from reading the code and
>> from an actual attempt:
>> debugs(28,8);
>> results in:
>> SBufStatsAction.cc:49:16: error: macro "debugs" requires 3 arguments,
>> but only 2 given
>>
>> This is irrelevant for the case at hand, as those debugs messages are
>> really pointless. Maybe making this optional parameter is an extension
>> in some branch other than trunk?
>
> Sorry. I suspect I was thinking about
>
> debugs(28,8, HERE);

Which type of message should probably be:
   debugs(28,8, "some reason for calling debugs(): cache.log looks quite
strange without it");

Some of the code use "Started" or "Done." strings for the reason.
Although yes, take a second and third look at whether they are necessary
at all.

Amos
Received on Thu Oct 10 2013 - 00:38:49 MDT