Re: [PATCH] Record SBuf and MemBlob sizes at destruct time

Hi,
  here's the updated patch (missing the Makefile.am bits, I'm
cherrypicking and it's just easier to do merge them by hand).
The merge will involve changesets 9679-9681, 9683,9687 of branch
lp:~squid/squid/stringng .

Thanks

On Sun, Nov 24, 2013 at 10:26 AM, Kinkie <gkinkie_at_gmail.com> wrote:
>>>> in src/SBufDetailedStats.cc
>>>> * please name the namespace
>>>
>>> What is the benefit? The code in there is just in order to have the
>>> post-init stuff done in StatHist, it's not meant to be seen anywhere
>>> else (so the anonymous namespace is really intentional). Not a big
>>> deal, but I'm curious.
>>
>> It will save on getting doxygen confused. And if we ever need to
>> reference inside that scope or add bits to it the namespace name
>> provides a hint as to what might be appropriate use.
>
> Ok, fair enough. I will add a name to it.
> Once that's done, may I submit?
> (btw: that post-init code is the result of StatHist C-ness, it should
> go away, I'd vebture by subclassing and polymorphism)
>
> Thanks
>
> --
> /kinkie

-- 
    /kinkie