Re: address field in ICP

Hiroyuki Inoue writes:

>Hi,
>
>When I was modifying ICP packet on squid, I noticed the field "shostid"
>of ICP packet is in wrong byte order with little endian host.
>This field should be represented in network byte order.
>
>In icp.c of squid-1.1.20, "shostid" field is converted with
>htonl() or ntohl() functions.
>It is not necessary to convert it, isn't it ?
>Because the address structure "struct in_addr" in the memory is always
>represented in network byte order on any host.
>In current squid implementaion it is not used, but I am worried...

Yes, I think you are correct....

I'll change it for the current versions.

Duane W.
Received on Tue Feb 10 1998 - 10:57:41 MST