Re: [squid-users] [patch] Re: [squid-users] X-Forwarded-For and cache_peer_access -- Fixed!

On Sat, 2013-08-10 at 14:27 +1200, Amos Jeffries wrote:
> Er. What Squid version are you using?
>
> The checklist() constructor pulls those details out of the request
> object itself in the current Squid versions.

The patch I provided was from trunk in the bazaar repo, but I'm actually
running squid 3.3.6 (with the 2 recent security patches added) both of
which set the checklist.src_addr after calling checklist().

> And the correct patch is to add:
>
> #if FOLLOW_X_FORWARDED_FOR
> if (Config.onoff.acl_uses_indirect_client)
> src_addr = request->indirect_client_addr;
> else
> #endif /* FOLLOW_X_FORWARDED_FOR */
> src_addr = request->client_addr;
>
> Amos

Thanks, I'll update the patch I am using.

-- 
Michael Graham <mgraham_at_bloxx.com>