Re: post modio

On Fri, May 12, 2000, Henrik Nordstrom wrote:
> Duane Wessels wrote:
>
> > The new storeDiskdDirCallback, however, doesn't loop over all dirs. It
> > blocks one just one dir at a time. In fact, the way its written now,
> > it would just chew up CPU needlessly. You might as well change
> > ICP_NOWAIT to "0" if away > magic2. The old storeDiskdReadQueue
> > also chewed up CPU, but I would not say that it was needless.
> >
> > Am I missing something?
>
> No you are not. Similar concerns applies to the aufs code.
>
> The callback should be a more generic kind where different I/O "modules"
> (Squid AIO, diskd, ...) can register themselves, and not directly tied
> to the cache_dir instances.

Hrm. Thats what I had initially for callback and sync due to AUFS. If
people think that having sync and callback per-fs type rather than per-fs
instance then I'll go through and change the API back. If we do this then
it'll be up to the fs code to maintain a list of swapdirs of their type,
or they have to walk the swapDir array and strcmp("type", SD->type) to
figure out whether is a swapdir of theirs.

Votes please.

Adrian
Received on Sun May 14 2000 - 03:15:54 MDT